sparse-checkout: free string list in write_cone_to_file()

peff · gitster · commit 2181fe6e464c · 2024-06-04T10:38:22.000-07:00
We use a string list to hold sorted and de-duped patterns, but don't
free it before leaving the function, causing a leak.

This drops the number of leaks found in t7002 from 27 to 25.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/sparse-checkout.c b/builtin/sparse-checkout.c
@@ -311,6 +311,8 @@ static void write_cone_to_file(FILE *fp, struct pattern_list *pl)
 		fprintf(fp, "%s/\n", pattern);
 		free(pattern);
 	}
+
+	string_list_clear(&sl, 0);
 }
 
 static int write_patterns_and_update(struct pattern_list *pl)

Original file line number	Diff line number	Diff line change
`@@ -311,6 +311,8 @@ static void write_cone_to_file(FILE fp, struct pattern_list pl)`
`311`	`311`	`fprintf(fp, "%s/\n", pattern);`
`312`	`312`	`free(pattern);`
`313`	`313`	`}`
	`314`	`+`
	`315`	`+ string_list_clear(&sl, 0);`
`314`	`316`	`}`
`315`	`317`
`316`	`318`	`static int write_patterns_and_update(struct pattern_list *pl)`