Skip to content

Commit 3965976

Browse files
newrengitster
authored andcommitted
merge-ort: support having merge verbosity be set to 0
Various callers such as am & checkout set the merge verbosity to 0 to avoid having conflict messages printed. While this could be achieved by avoiding the wrappers from merge-ort-wrappers and instead passing 0 for display_update_msgs to merge_switch_to_result(), for simplicity of converting callers simply allow them to also achieve this with the merge-ort-wrappers by setting verbosity to 0. Signed-off-by: Elijah Newren <[email protected]> Reviewed-by: Taylor Blau <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent a707d4f commit 3965976

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

merge-ort-wrappers.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ int merge_ort_nonrecursive(struct merge_options *opt,
3333
struct tree *merge_base)
3434
{
3535
struct merge_result result;
36+
int show_msgs;
3637

3738
if (unclean(opt, head))
3839
return -1;
@@ -42,9 +43,10 @@ int merge_ort_nonrecursive(struct merge_options *opt,
4243
return 1;
4344
}
4445

46+
show_msgs = !!opt->verbosity;
4547
memset(&result, 0, sizeof(result));
4648
merge_incore_nonrecursive(opt, merge_base, head, merge, &result);
47-
merge_switch_to_result(opt, head, &result, 1, 1);
49+
merge_switch_to_result(opt, head, &result, 1, show_msgs);
4850

4951
return result.clean;
5052
}
@@ -57,13 +59,15 @@ int merge_ort_recursive(struct merge_options *opt,
5759
{
5860
struct tree *head = repo_get_commit_tree(opt->repo, side1);
5961
struct merge_result tmp;
62+
int show_msgs;
6063

6164
if (unclean(opt, head))
6265
return -1;
6366

67+
show_msgs = !!opt->verbosity;
6468
memset(&tmp, 0, sizeof(tmp));
6569
merge_incore_recursive(opt, merge_bases, side1, side2, &tmp);
66-
merge_switch_to_result(opt, head, &tmp, 1, 1);
70+
merge_switch_to_result(opt, head, &tmp, 1, show_msgs);
6771
*result = NULL;
6872

6973
return tmp.clean;

0 commit comments

Comments
 (0)