gc: mark unused config parameter in virtual functions

peff · gitster · commit 551e4de8e1f0 · 2024-08-28T09:51:17.000-07:00
Commit d1ae15d (builtin/gc: refactor to read config into structure, 2024-08-16) added a new parameter to the maintenance_task virtual functions, but most of them don't need to look at it. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/builtin/gc.c b/builtin/gc.c
@@ -967,7 +967,7 @@ static int dfs_on_ref(const char *refname UNUSED,
 	return result;
 }
 
-static int should_write_commit_graph(struct gc_config *cfg)
+static int should_write_commit_graph(struct gc_config *cfg UNUSED)
 {
 	int result;
 	struct cg_auto_data data;
@@ -1005,7 +1005,7 @@ static int run_write_commit_graph(struct maintenance_run_opts *opts)
 }
 
 static int maintenance_task_commit_graph(struct maintenance_run_opts *opts,
-					 struct gc_config *cfg)
+					 struct gc_config *cfg UNUSED)
 {
 	prepare_repo_settings(the_repository);
 	if (!the_repository->settings.core_commit_graph)
@@ -1040,7 +1040,7 @@ static int fetch_remote(struct remote *remote, void *cbdata)
 }
 
 static int maintenance_task_prefetch(struct maintenance_run_opts *opts,
-				     struct gc_config *cfg)
+				     struct gc_config *cfg UNUSED)
 {
 	if (for_each_remote(fetch_remote, opts)) {
 		error(_("failed to prefetch remotes"));
@@ -1051,7 +1051,7 @@ static int maintenance_task_prefetch(struct maintenance_run_opts *opts,
 }
 
 static int maintenance_task_gc(struct maintenance_run_opts *opts,
-			       struct gc_config *cfg)
+			       struct gc_config *cfg UNUSED)
 {
 	struct child_process child = CHILD_PROCESS_INIT;
 
@@ -1100,7 +1100,7 @@ static int loose_object_count(const struct object_id *oid UNUSED,
 	return 0;
 }
 
-static int loose_object_auto_condition(struct gc_config *cfg)
+static int loose_object_auto_condition(struct gc_config *cfg UNUSED)
 {
 	int count = 0;
 
@@ -1192,12 +1192,12 @@ static int pack_loose(struct maintenance_run_opts *opts)
 }
 
 static int maintenance_task_loose_objects(struct maintenance_run_opts *opts,
-					  struct gc_config *cfg)
+					  struct gc_config *cfg UNUSED)
 {
 	return prune_packed(opts) || pack_loose(opts);
 }
 
-static int incremental_repack_auto_condition(struct gc_config *cfg)
+static int incremental_repack_auto_condition(struct gc_config *cfg UNUSED)
 {
 	struct packed_git *p;
 	int incremental_repack_auto_limit = 10;
@@ -1317,7 +1317,7 @@ static int multi_pack_index_repack(struct maintenance_run_opts *opts)
 }
 
 static int maintenance_task_incremental_repack(struct maintenance_run_opts *opts,
-					       struct gc_config *cfg)
+					       struct gc_config *cfg UNUSED)
 {
 	prepare_repo_settings(the_repository);
 	if (!the_repository->settings.core_multi_pack_index) {

Original file line number	Diff line number	Diff line change
`@@ -967,7 +967,7 @@ static int dfs_on_ref(const char *refname UNUSED,`
`967`	`967`	`return result;`
`968`	`968`	`}`
`969`	`969`
`970`		`-static int should_write_commit_graph(struct gc_config *cfg)`
	`970`	`+static int should_write_commit_graph(struct gc_config *cfg UNUSED)`
`971`	`971`	`{`
`972`	`972`	`int result;`
`973`	`973`	`struct cg_auto_data data;`
`@@ -1005,7 +1005,7 @@ static int run_write_commit_graph(struct maintenance_run_opts *opts)`
`1005`	`1005`	`}`
`1006`	`1006`
`1007`	`1007`	`static int maintenance_task_commit_graph(struct maintenance_run_opts *opts,`
`1008`		`- struct gc_config *cfg)`
	`1008`	`+ struct gc_config *cfg UNUSED)`
`1009`	`1009`	`{`
`1010`	`1010`	`prepare_repo_settings(the_repository);`
`1011`	`1011`	`if (!the_repository->settings.core_commit_graph)`
`@@ -1040,7 +1040,7 @@ static int fetch_remote(struct remote remote, void cbdata)`
`1040`	`1040`	`}`
`1041`	`1041`
`1042`	`1042`	`static int maintenance_task_prefetch(struct maintenance_run_opts *opts,`
`1043`		`- struct gc_config *cfg)`
	`1043`	`+ struct gc_config *cfg UNUSED)`
`1044`	`1044`	`{`
`1045`	`1045`	`if (for_each_remote(fetch_remote, opts)) {`
`1046`	`1046`	`error(_("failed to prefetch remotes"));`
`@@ -1051,7 +1051,7 @@ static int maintenance_task_prefetch(struct maintenance_run_opts *opts,`
`1051`	`1051`	`}`
`1052`	`1052`
`1053`	`1053`	`static int maintenance_task_gc(struct maintenance_run_opts *opts,`
`1054`		`- struct gc_config *cfg)`
	`1054`	`+ struct gc_config *cfg UNUSED)`
`1055`	`1055`	`{`
`1056`	`1056`	`struct child_process child = CHILD_PROCESS_INIT;`
`1057`	`1057`
`@@ -1100,7 +1100,7 @@ static int loose_object_count(const struct object_id *oid UNUSED,`
`1100`	`1100`	`return 0;`
`1101`	`1101`	`}`
`1102`	`1102`
`1103`		`-static int loose_object_auto_condition(struct gc_config *cfg)`
	`1103`	`+static int loose_object_auto_condition(struct gc_config *cfg UNUSED)`
`1104`	`1104`	`{`
`1105`	`1105`	`int count = 0;`
`1106`	`1106`
`@@ -1192,12 +1192,12 @@ static int pack_loose(struct maintenance_run_opts *opts)`
`1192`	`1192`	`}`
`1193`	`1193`
`1194`	`1194`	`static int maintenance_task_loose_objects(struct maintenance_run_opts *opts,`
`1195`		`- struct gc_config *cfg)`
	`1195`	`+ struct gc_config *cfg UNUSED)`
`1196`	`1196`	`{`
`1197`	`1197`	`return prune_packed(opts) \|\| pack_loose(opts);`
`1198`	`1198`	`}`
`1199`	`1199`
`1200`		`-static int incremental_repack_auto_condition(struct gc_config *cfg)`
	`1200`	`+static int incremental_repack_auto_condition(struct gc_config *cfg UNUSED)`
`1201`	`1201`	`{`
`1202`	`1202`	`struct packed_git *p;`
`1203`	`1203`	`int incremental_repack_auto_limit = 10;`
`@@ -1317,7 +1317,7 @@ static int multi_pack_index_repack(struct maintenance_run_opts *opts)`
`1317`	`1317`	`}`
`1318`	`1318`
`1319`	`1319`	`static int maintenance_task_incremental_repack(struct maintenance_run_opts *opts,`
`1320`		`- struct gc_config *cfg)`
	`1320`	`+ struct gc_config *cfg UNUSED)`
`1321`	`1321`	`{`
`1322`	`1322`	`prepare_repo_settings(the_repository);`
`1323`	`1323`	`if (!the_repository->settings.core_multi_pack_index) {`