Skip to content

Commit 6ea26f3

Browse files
peffgitster
authored andcommitted
t5516: drop NEEDSWORK about v2 reachability behavior
When this test was added in 6c301ad (fetch: do not pass ref-prefixes for fetch by exact SHA1, 2018-05-31), there was still some uncertainty about the v2 protocol's looser behavior with serving objects that are not directly pointed at by a ref. At this point that behavior is well established, and I do not think we would ever change v2 to match the v0 behavior (and if we did, remembering to update this test is the least of our concerns). Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 2de68c0 commit 6ea26f3

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

t/t5516-fetch-push.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1312,7 +1312,6 @@ test_expect_success 'fetch exact oid in protocol v2' '
13121312
test_must_fail git -C child cat-file -t $the_commit &&
13131313
13141314
# fetching the hidden object succeeds by default
1315-
# NEEDSWORK: should this match the v0 behavior instead?
13161315
git -C child fetch -v ../testrepo $the_commit:refs/heads/copy
13171316
'
13181317

0 commit comments

Comments
 (0)