Skip to content

Commit f52c9a2

Browse files
committed
__attribute__: remove redundant attribute declaration for git_die_config()
The convention is to declare the function attribute to an extern function together with its declaration in the header file, without repeating the attribute declaration with its definition in the .c source file (a file-scope static function declares its attribute together with its definition in the .c file it is defined, as there is no other place to do so). The definition of git_die_config() in config.c did not follow the convention and had its attribute declared with both its declaration in the header and its definition in the .c source file. Remove the one in the config.c to match everybody else. Signed-off-by: Junio C Hamano <[email protected]>
1 parent 89e78c7 commit f52c9a2

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

config.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2822,7 +2822,6 @@ void git_die_config_linenr(const char *key, const char *filename, int linenr)
28222822
key, filename, linenr);
28232823
}
28242824

2825-
NORETURN __attribute__((format(printf, 2, 3)))
28262825
void git_die_config(const char *key, const char *err, ...)
28272826
{
28282827
const struct string_list *values;

0 commit comments

Comments
 (0)