Skip to content

Commit 019a103

Browse files
committed
Merge branch 'jc/format-patch-v-unleak'
Plug a small leak. * jc/format-patch-v-unleak: format-patch: unleak "-v <num>"
2 parents 6e0f966 + 5b8db44 commit 019a103

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

builtin/log.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1875,6 +1875,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
18751875
struct strbuf rdiff1 = STRBUF_INIT;
18761876
struct strbuf rdiff2 = STRBUF_INIT;
18771877
struct strbuf rdiff_title = STRBUF_INIT;
1878+
struct strbuf sprefix = STRBUF_INIT;
18781879
int creation_factor = -1;
18791880

18801881
const struct option builtin_format_patch_options[] = {
@@ -2015,12 +2016,10 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
20152016
cover_from_description_mode = parse_cover_from_description(cover_from_description_arg);
20162017

20172018
if (reroll_count) {
2018-
struct strbuf sprefix = STRBUF_INIT;
2019-
20202019
strbuf_addf(&sprefix, "%s v%s",
20212020
rev.subject_prefix, reroll_count);
20222021
rev.reroll_count = reroll_count;
2023-
rev.subject_prefix = strbuf_detach(&sprefix, NULL);
2022+
rev.subject_prefix = sprefix.buf;
20242023
}
20252024

20262025
for (i = 0; i < extra_hdr.nr; i++) {
@@ -2384,6 +2383,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
23842383
strbuf_release(&rdiff1);
23852384
strbuf_release(&rdiff2);
23862385
strbuf_release(&rdiff_title);
2386+
strbuf_release(&sprefix);
23872387
free(to_free);
23882388
if (rev.ref_message_ids)
23892389
string_list_clear(rev.ref_message_ids, 0);

0 commit comments

Comments
 (0)