Skip to content

Commit 01b89f0

Browse files
Oblomovgitster
authored andcommitted
gitweb: pull ref markes pull out of subject <a> element
Since 4afbaef (gitweb: ref markers link to named shortlogs, 2008-09-02), ref markers that accompany the subject in views such as shortlog and history point to something different from the subject itself. Therefore, they should not be included in the same <a> element. Benefits of the change are: * better compliance to the XHTML standards, that forbid links within links even though the restriction cannot be imposed via DTD; this also benefits visualization in some older browsers; * when hovering the subject, only the subject itself is underlined; when hovering the ref markers, only the text in the hovered ref marker is underlined; previously, hovering any written part of the subject column led to complete underlying of everything at the same time, with unpleasing effects. Signed-off-by: Giuseppe Bilotta <[email protected]> Acked-by: Jakub Narebski <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 32f4cc4 commit 01b89f0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

gitweb/gitweb.perl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1513,10 +1513,10 @@ sub format_subject_html {
15131513
$long =~ s/[[:cntrl:]]/?/g;
15141514
return $cgi->a({-href => $href, -class => "list subject",
15151515
-title => to_utf8($long)},
1516-
esc_html($short) . $extra);
1516+
esc_html($short)) . $extra;
15171517
} else {
15181518
return $cgi->a({-href => $href, -class => "list subject"},
1519-
esc_html($long) . $extra);
1519+
esc_html($long)) . $extra;
15201520
}
15211521
}
15221522

0 commit comments

Comments
 (0)