Skip to content

Commit 01e60a9

Browse files
realsobekgitster
authored andcommitted
doc: update SubmittingPatches
-use US English spelling -minor wording change for better readability Helped-by: Stefan Beller <[email protected]> Signed-off-by: René Genz <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 49800c9 commit 01e60a9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Documentation/SubmittingPatches

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ If your description starts to get too long, that's a sign that you
5151
probably need to split up your commit to finer grained pieces.
5252
That being said, patches which plainly describe the things that
5353
help reviewers check the patch, and future maintainers understand
54-
the code, are the most beautiful patches. Descriptions that summarise
54+
the code, are the most beautiful patches. Descriptions that summarize
5555
the point in the subject well, and describe the motivation for the
5656
change, the approach taken by the change, and if relevant how this
5757
differs substantially from the prior version, are all good things
@@ -87,7 +87,7 @@ patches separate from other documentation changes.
8787
Oh, another thing. We are picky about whitespaces. Make sure your
8888
changes do not trigger errors with the sample pre-commit hook shipped
8989
in templates/hooks--pre-commit. To help ensure this does not happen,
90-
run git diff --check on your changes before you commit.
90+
run "git diff --check" on your changes before you commit.
9191

9292

9393
(2) Describe your changes well.
@@ -106,18 +106,18 @@ files you are modifying to see the current conventions.
106106

107107
The body should provide a meaningful commit message, which:
108108

109-
. explains the problem the change tries to solve, iow, what is wrong
109+
. explains the problem the change tries to solve, i.e. what is wrong
110110
with the current code without the change.
111111

112-
. justifies the way the change solves the problem, iow, why the
112+
. justifies the way the change solves the problem, i.e. why the
113113
result with the change is better.
114114

115115
. alternate solutions considered but discarded, if any.
116116

117117
Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
118118
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
119119
to do frotz", as if you are giving orders to the codebase to change
120-
its behaviour. Try to make sure your explanation can be understood
120+
its behavior. Try to make sure your explanation can be understood
121121
without external resources. Instead of giving a URL to a mailing list
122122
archive, summarize the relevant points of the discussion.
123123

@@ -255,7 +255,7 @@ smaller project it is a good discipline to follow it.
255255
The sign-off is a simple line at the end of the explanation for
256256
the patch, which certifies that you wrote it or otherwise have
257257
the right to pass it on as a open-source patch. The rules are
258-
pretty simple: if you can certify the below:
258+
pretty simple: if you can certify the below D-C-O:
259259

260260
Developer's Certificate of Origin 1.1
261261

0 commit comments

Comments
 (0)