Skip to content

Commit 04e340b

Browse files
committed
Merge branch 'mb/p4-fixes'
Fix a few issues in "git p4". * mb/p4-fixes: git-p4: fix error handling in P4Unshelve.renameBranch() git-p4: fix typo in P4Submit.applyCommit()
2 parents 13d0c00 + 198551c commit 04e340b

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

git-p4.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2226,7 +2226,7 @@ def applyCommit(self, id):
22262226
raw=True):
22272227
if regexp.search(line):
22282228
if verbose:
2229-
print("got keyword match on %s in %s in %s" % (regex.pattern, line, file))
2229+
print("got keyword match on %s in %s in %s" % (regexp.pattern, line, file))
22302230
kwfiles[file] = regexp
22312231
break
22322232

@@ -4369,19 +4369,16 @@ def __init__(self):
43694369
def renameBranch(self, branch_name):
43704370
"""Rename the existing branch to branch_name.N ."""
43714371

4372-
found = True
43734372
for i in range(0, 1000):
43744373
backup_branch_name = "{0}.{1}".format(branch_name, i)
43754374
if not gitBranchExists(backup_branch_name):
43764375
# Copy ref to backup
43774376
gitUpdateRef(backup_branch_name, branch_name)
43784377
gitDeleteRef(branch_name)
4379-
found = True
43804378
print("renamed old unshelve branch to {0}".format(backup_branch_name))
43814379
break
4382-
4383-
if not found:
4384-
sys.exit("gave up trying to rename existing branch {0}".format(sync.branch))
4380+
else:
4381+
sys.exit("gave up trying to rename existing branch {0}".format(branch_name))
43854382

43864383
def findLastP4Revision(self, starting_point):
43874384
"""Look back from starting_point for the first commit created by git-p4

0 commit comments

Comments
 (0)