Skip to content

Commit 05a5869

Browse files
KellerFuchsgitster
authored andcommitted
Documentation: clarify signature verification
Clarify that "merge --verify-signatures" checks the signature on the tip commit of the history being merged. Uniformise the vocabulary used wrt. key/signature validity with OpenPGP: - a signature is valid if made by a key with a valid uid; - in the default trust-model, a uid is valid if signed by a trusted key; - a key is trusted if the (local) user set a trust level for it. Helped-by: Junio C Hamano <[email protected]> Signed-off-by: Keller Fuchs <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 90f7b16 commit 05a5869

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

Documentation/merge-options.txt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,11 @@ option can be used to override --squash.
8989

9090
--verify-signatures::
9191
--no-verify-signatures::
92-
Verify that the commits being merged have good and trusted GPG signatures
93-
and abort the merge in case they do not.
92+
Verify that the tip commit of the side branch being merged is
93+
signed with a valid key, i.e. a key that has a valid uid: in the
94+
default trust model, this means the signing key has been signed by
95+
a trusted key. If the tip commit of the side branch is not signed
96+
with a valid key, the merge is aborted.
9497

9598
--summary::
9699
--no-summary::

Documentation/pretty-formats.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ ifndef::git-rev-list[]
143143
- '%N': commit notes
144144
endif::git-rev-list[]
145145
- '%GG': raw verification message from GPG for a signed commit
146-
- '%G?': show "G" for a Good signature, "B" for a Bad signature, "U" for a good,
147-
untrusted signature and "N" for no signature
146+
- '%G?': show "G" for a good (valid) signature, "B" for a bad signature,
147+
"U" for a good signature with unknown validity and "N" for no signature
148148
- '%GS': show the name of the signer for a signed commit
149149
- '%GK': show the key used to sign a signed commit
150150
- '%gD': reflog selector, e.g., `refs/stash@{1}`

0 commit comments

Comments
 (0)