Skip to content

Commit 05bdcfe

Browse files
jastgitster
authored andcommitted
git-am: suggest what to do with superfluous patches
Particularly in the context of rebase, conflicts frequently occur because the change in the patch to be applied was made obsolete by new upstream commits. In this case, solving the conflict effectively means skipping the patch. However, it's not always readily apparent that the patch needs to be skipped, and when people solve the conflict and try git rebase --continue, they get confronted with a message of No changes - did you forget to use 'git add'? That's not very helpful if you did actually stage your changes and they happen to turn the patch into a no-op. This extends the message to point out what's going on. Signed-off-by: Jan Krüger <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 81fa024 commit 05bdcfe

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

git-am.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -726,6 +726,8 @@ do
726726
resolved=
727727
git diff-index --quiet --cached HEAD -- && {
728728
echo "No changes - did you forget to use 'git add'?"
729+
echo "If there is nothing left to stage, chances are that something else"
730+
echo "already introduced the same changes; you might want to skip this patch."
729731
stop_here_user_resolve $this
730732
}
731733
unmerged=$(git ls-files -u)

0 commit comments

Comments
 (0)