Skip to content

Commit 06038cd

Browse files
peffgitster
authored andcommitted
git_push_config: drop cargo-culted wt_status pointer
The push config callback does not expect any incoming data via the void pointer. And if it did, it would certainly not be a "struct wt_status". This probably got picked up accidentally in b945901 (push: heed user.signingkey for signed pushes, 2014-10-22), which copied the template for the config callback from builtin/commit.c. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 18d0fec commit 06038cd

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

builtin/push.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -473,13 +473,12 @@ static int option_parse_recurse_submodules(const struct option *opt,
473473

474474
static int git_push_config(const char *k, const char *v, void *cb)
475475
{
476-
struct wt_status *s = cb;
477476
int status;
478477

479478
status = git_gpg_config(k, v, NULL);
480479
if (status)
481480
return status;
482-
return git_default_config(k, v, s);
481+
return git_default_config(k, v, NULL);
483482
}
484483

485484
int cmd_push(int argc, const char **argv, const char *prefix)

0 commit comments

Comments
 (0)