config.c: mark die_bad_number as NORETURN

peff · gitster · commit 06bdc23b7e5b · 2014-04-16T10:21:14.000-07:00
This can help avoid -Wuninitialized false positives in
git_config_int and git_config_ulong, as the compiler now
knows that we do not return "ret" if we hit the error
codepath.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/config.c b/config.c
@@ -552,6 +552,7 @@ int git_parse_ulong(const char *value, unsigned long *ret)
 	return 1;
 }
 
+NORETURN
 static void die_bad_number(const char *name, const char *value)
 {
 	const char *reason = errno == ERANGE ?

Original file line number	Diff line number	Diff line change
`@@ -552,6 +552,7 @@ int git_parse_ulong(const char value, unsigned long ret)`
`552`	`552`	`return 1;`
`553`	`553`	`}`
`554`	`554`
	`555`	`+NORETURN`
`555`	`556`	`static void die_bad_number(const char name, const char value)`
`556`	`557`	`{`
`557`	`558`	`const char *reason = errno == ERANGE ?`