Skip to content

Commit 06c21e1

Browse files
peffgitster
authored andcommitted
cmd_push: pass "flags" pointer to config callback
This will let us manipulate any transport flags which have matching config options (there are none yet, but we will add one in the next patch). We could also just make "flags" a static file-scope global, but the result is a little confusing. We end up passing it along through do_push and push_with_options, each of which further munge it. Having slightly-differing versions of the flags variable available to those functions would probably cause more confusion than it is worth. Let's just keep the original local to cmd_push, and it can continue to pass it through the call-stack. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d16c33b commit 06c21e1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

builtin/push.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ int cmd_push(int argc, const char **argv, const char *prefix)
522522
};
523523

524524
packet_trace_identity("push");
525-
git_config(git_push_config, NULL);
525+
git_config(git_push_config, &flags);
526526
argc = parse_options(argc, argv, prefix, options, push_usage, 0);
527527

528528
if (deleterefs && (tags || (flags & (TRANSPORT_PUSH_ALL | TRANSPORT_PUSH_MIRROR))))

0 commit comments

Comments
 (0)