unpack-trees: avoid dead store for struct progress

carenas · gitster · commit 07f967adb55f · 2018-10-19T11:16:52.000+09:00
it is unconditionally initialized a few lines below

Signed-off-by: Carlo Marcelo Arenas Belón &lt;carenas@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/unpack-trees.c b/unpack-trees.c
@@ -380,7 +380,7 @@ static int check_updates(struct unpack_trees_options *o)
 {
 	unsigned cnt = 0;
 	int errs = 0;
-	struct progress *progress = NULL;
+	struct progress *progress;
 	struct index_state *index = &o->result;
 	struct checkout state = CHECKOUT_INIT;
 	int i;

Original file line number	Diff line number	Diff line change
`@@ -380,7 +380,7 @@ static int check_updates(struct unpack_trees_options *o)`
`380`	`380`	`{`
`381`	`381`	`unsigned cnt = 0;`
`382`	`382`	`int errs = 0;`
`383`		`- struct progress *progress = NULL;`
	`383`	`+ struct progress *progress;`
`384`	`384`	`struct index_state *index = &o->result;`
`385`	`385`	`struct checkout state = CHECKOUT_INIT;`
`386`	`386`	`int i;`