Skip to content

Commit 0a6d475

Browse files
aspiersgitster
authored andcommitted
tests: change info messages from yellow/brown to cyan
Now that we've adopted a "traffic lights" coloring scheme, yellow is used for warning messages, so we need to re-color info messages to something less alarmist. Blue is a universal color for informational messages; however we are using that for skipped tests in order to align with the color schemes of other test suites. Therefore we use cyan which is also blue-ish, but visually distinct from blue. This was suggested on the list a while ago and no-one raised any objections: http://thread.gmane.org/gmane.comp.version-control.git/205675/focus=205966 An earlier iteration of this patch used bold cyan, but the point of this change is to make them less alarming; let's drop the boldness. Also paint the message to report skipping the whole thing via GIT_SKIP_TESTS mechanism in the same color as the "info" color that is used on the final summary line for the entire script. Signed-off-by: Adam Spiers <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b8fc855 commit 0a6d475

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

t/test-lib.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,9 @@ then
186186
warn)
187187
tput setaf 3;; # brown/yellow
188188
pass)
189-
tput setaf 2;; # green
189+
tput setaf 2;; # green
190190
info)
191-
tput setaf 3;; # brown
191+
tput setaf 6;; # cyan
192192
*)
193193
test -n "$quiet" && return;;
194194
esac
@@ -584,7 +584,7 @@ for skp in $GIT_SKIP_TESTS
584584
do
585585
case "$this_test" in
586586
$skp)
587-
say_color skip >&3 "skipping test $this_test altogether"
587+
say_color info >&3 "skipping test $this_test altogether"
588588
skip_all="skip all tests in $this_test"
589589
test_done
590590
esac

0 commit comments

Comments
 (0)