Skip to content

Commit 0aa7a78

Browse files
peffgitster
authored andcommitted
smart-http: document flush after "# service" line
The http-protocol.txt spec fails to mention that a flush packet comes in the smart server response after sending the "service" header. Technically the client code is actually ready to receive an arbitrary number of headers here, but since we haven't introduced any other headers in the past decade (and the client would just throw them away), let's not mention it in the spec. This fixes both BNF and the example. While we're fixing the latter, let's also add the missing flush after the ref list. Reported-by: Dorian Taylor <[email protected]> Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 38e79b1 commit 0aa7a78

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Documentation/technical/http-protocol.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,10 +214,12 @@ smart server reply:
214214
S: Cache-Control: no-cache
215215
S:
216216
S: 001e# service=git-upload-pack\n
217+
S: 0000
217218
S: 004895dcfa3633004da0049d3d0fa03f80589cbcaf31 refs/heads/maint\0multi_ack\n
218219
S: 0042d049f6c27a2244e12041955e262a404c7faba355 refs/heads/master\n
219220
S: 003c2cb58b79488a98d2721cea644875a8dd0026b115 refs/tags/v1.0\n
220221
S: 003fa3c2e2402b99163d1d59756e5f207ae21cccba4c refs/tags/v1.0^{}\n
222+
S: 0000
221223

222224
The client may send Extra Parameters (see
223225
Documentation/technical/pack-protocol.txt) as a colon-separated string
@@ -277,6 +279,7 @@ The returned response contains "version 1" if "version=1" was sent as an
277279
Extra Parameter.
278280

279281
smart_reply = PKT-LINE("# service=$servicename" LF)
282+
"0000"
280283
*1("version 1")
281284
ref_list
282285
"0000"

0 commit comments

Comments
 (0)