Skip to content

Commit 0c4030c

Browse files
winksavillegitster
authored andcommitted
rebase-interactive: simplify pick_on_preserving_merges
Use compound if statement instead of nested if statements to simplify pick_on_preserving_merges. Signed-off-by: Wink Saville <[email protected]> Acked-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 90bbd50 commit 0c4030c

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

git-rebase--interactive.sh

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -307,17 +307,14 @@ pick_one_preserving_merges () {
307307
esac
308308
sha1=$(git rev-parse $sha1)
309309

310-
if test -f "$state_dir"/current-commit
310+
if test -f "$state_dir"/current-commit && test "$fast_forward" = t
311311
then
312-
if test "$fast_forward" = t
313-
then
314-
while read current_commit
315-
do
316-
git rev-parse HEAD > "$rewritten"/$current_commit
317-
done <"$state_dir"/current-commit
318-
rm "$state_dir"/current-commit ||
319-
die "$(gettext "Cannot write current commit's replacement sha1")"
320-
fi
312+
while read current_commit
313+
do
314+
git rev-parse HEAD > "$rewritten"/$current_commit
315+
done <"$state_dir"/current-commit
316+
rm "$state_dir"/current-commit ||
317+
die "$(gettext "Cannot write current commit's replacement sha1")"
321318
fi
322319

323320
echo $sha1 >> "$state_dir"/current-commit

0 commit comments

Comments
 (0)