Skip to content

Commit 0d83d82

Browse files
newrengitster
authored andcommitted
merge-ort: mark conflict/warning messages from inner merges as omittable
A recursive merge involves merging the merge bases of the two branches being merged. Such an inner merge can itself generate conflict notices. While such notices may be useful when initially trying to create a merge, they seem to just be noise when investigating merges later with --remerge-diff. (Especially when both sides of the outer merge resolved the conflict the same way leading to no overall conflict.) Remove them. Signed-off-by: Elijah Newren <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 20323d1 commit 0d83d82

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

merge-ort.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,9 @@ static void path_msg(struct merge_options *opt,
638638
struct strbuf tmp = STRBUF_INIT;
639639

640640
if (opt->record_conflict_msgs_as_headers && omittable_hint)
641-
return; /* Do not record mere hints in tree */
641+
return; /* Do not record mere hints in headers */
642+
if (opt->record_conflict_msgs_as_headers && opt->priv->call_depth)
643+
return; /* Do not record inner merge issues in headers */
642644
sb = strmap_get(&opt->priv->output, path);
643645
if (!sb) {
644646
sb = xmalloc(sizeof(*sb));

0 commit comments

Comments
 (0)