Skip to content

Commit 0da4b53

Browse files
sgnttaylorr
authored andcommitted
bisect--helper: log: allow arbitrary number of arguments
In a later change, we would like to turn bisect into a builtin by renaming bisect--helper. However, there's an oddity that "git bisect log" accepts any number of arguments and it will just ignore them all. Let's prepare for the next step by ignoring any arguments passed to "git bisect--helper log" Signed-off-by: Đoàn Trần Công Danh <[email protected]> Signed-off-by: Taylor Blau <[email protected]>
1 parent df63421 commit 0da4b53

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

builtin/bisect--helper.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,10 +1347,8 @@ static int cmd_bisect__next(int argc, const char **argv UNUSED, const char *pref
13471347
return res;
13481348
}
13491349

1350-
static int cmd_bisect__log(int argc, const char **argv UNUSED, const char *prefix UNUSED)
1350+
static int cmd_bisect__log(int argc UNUSED, const char **argv UNUSED, const char *prefix UNUSED)
13511351
{
1352-
if (argc)
1353-
return error(_("'%s' requires 0 arguments"), "git bisect log");
13541352
return bisect_log();
13551353
}
13561354

git-bisect.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ case "$#" in
5757
case "$cmd" in
5858
help)
5959
git bisect -h ;;
60-
log)
61-
git bisect--helper log || exit ;;
6260
*)
6361
git bisect--helper "$cmd" "$@" ;;
6462
esac

0 commit comments

Comments
 (0)