t3900: test rejecting log message with NULs correctly

gitster · gitster · commit 0ed45a1cd657 · 2013-08-05T09:47:11.000-07:00
It is not like that our longer term desire is to someday start
accept log messages with NULs in them, so it is wrong to mark a test
that demonstrates "git commit" that correctly fails given such an
input as "expect-failure".  "git commit" should fail today, and it
should fail the same way in the future given a message with NUL in it.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t3900-i18n-commit.sh b/t/t3900-i18n-commit.sh
@@ -34,9 +34,9 @@ test_expect_success 'no encoding header for base case' '
 	test z = "z$E"
 '
 
-test_expect_failure 'UTF-16 refused because of NULs' '
+test_expect_success 'UTF-16 refused because of NULs' '
 	echo UTF-16 >F &&
-	git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt
+	test_must_fail git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt
 '
 
 

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,9 @@ test_expect_success 'no encoding header for base case' '`
`34`	`34`	`test z = "z$E"`
`35`	`35`	`'`
`36`	`36`
`37`		`-test_expect_failure 'UTF-16 refused because of NULs' '`
	`37`	`+test_expect_success 'UTF-16 refused because of NULs' '`
`38`	`38`	`echo UTF-16 >F &&`
`39`		`- git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt`
	`39`	`+ test_must_fail git commit -a -F "$TEST_DIRECTORY"/t3900/UTF-16.txt`
`40`	`40`	`'`
`41`	`41`
`42`	`42`