Skip to content

Commit 0f84695

Browse files
phordgitster
authored andcommitted
refs: remove old refs_warn_dangling_symref
The dangling warning function that takes a single ref to search for is no longer used. Remove it. Signed-off-by: Phil Hord <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent cc7dc40 commit 0f84695

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

refs.c

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,6 @@ static int for_each_filter_refs(const char *refname, const char *referent,
438438
struct warn_if_dangling_data {
439439
struct ref_store *refs;
440440
FILE *fp;
441-
const char *refname;
442441
const struct string_list *refnames;
443442
const char *msg_fmt;
444443
};
@@ -455,9 +454,7 @@ static int warn_if_dangling_symref(const char *refname, const char *referent UNU
455454

456455
resolves_to = refs_resolve_ref_unsafe(d->refs, refname, 0, NULL, NULL);
457456
if (!resolves_to
458-
|| (d->refname
459-
? strcmp(resolves_to, d->refname)
460-
: !string_list_has_string(d->refnames, resolves_to))) {
457+
|| !string_list_has_string(d->refnames, resolves_to)) {
461458
return 0;
462459
}
463460

@@ -466,18 +463,6 @@ static int warn_if_dangling_symref(const char *refname, const char *referent UNU
466463
return 0;
467464
}
468465

469-
void refs_warn_dangling_symref(struct ref_store *refs, FILE *fp,
470-
const char *msg_fmt, const char *refname)
471-
{
472-
struct warn_if_dangling_data data = {
473-
.refs = refs,
474-
.fp = fp,
475-
.refname = refname,
476-
.msg_fmt = msg_fmt,
477-
};
478-
refs_for_each_rawref(refs, warn_if_dangling_symref, &data);
479-
}
480-
481466
void refs_warn_dangling_symrefs(struct ref_store *refs, FILE *fp,
482467
const char *msg_fmt, const struct string_list *refnames)
483468
{

refs.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -435,8 +435,6 @@ static inline const char *has_glob_specials(const char *pattern)
435435
return strpbrk(pattern, "?*[");
436436
}
437437

438-
void refs_warn_dangling_symref(struct ref_store *refs, FILE *fp,
439-
const char *msg_fmt, const char *refname);
440438
void refs_warn_dangling_symrefs(struct ref_store *refs, FILE *fp,
441439
const char *msg_fmt, const struct string_list *refnames);
442440

0 commit comments

Comments
 (0)