Skip to content

Commit 10761eb

Browse files
rscharfegitster
authored andcommitted
wt-status: simplify building of summary limit argument
Use argv_array_pushf for building the number string for the option --summary-limit directly instead of using an intermediate buffer. Signed-off-by: Rene Scharfe <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 85dd6bf commit 10761eb

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

wt-status.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -734,23 +734,21 @@ static void wt_status_print_changed(struct wt_status *s)
734734
static void wt_status_print_submodule_summary(struct wt_status *s, int uncommitted)
735735
{
736736
struct child_process sm_summary;
737-
char summary_limit[64];
738737
struct argv_array env = ARGV_ARRAY_INIT;
739738
struct argv_array argv = ARGV_ARRAY_INIT;
740739
struct strbuf cmd_stdout = STRBUF_INIT;
741740
struct strbuf summary = STRBUF_INIT;
742741
char *summary_content;
743742
size_t len;
744743

745-
sprintf(summary_limit, "%d", s->submodule_summary);
746744
argv_array_pushf(&env, "GIT_INDEX_FILE=%s", s->index_file);
747745

748746
argv_array_push(&argv, "submodule");
749747
argv_array_push(&argv, "summary");
750748
argv_array_push(&argv, uncommitted ? "--files" : "--cached");
751749
argv_array_push(&argv, "--for-status");
752750
argv_array_push(&argv, "--summary-limit");
753-
argv_array_push(&argv, summary_limit);
751+
argv_array_pushf(&argv, "%d", s->submodule_summary);
754752
if (!uncommitted)
755753
argv_array_push(&argv, s->amend ? "HEAD^" : "HEAD");
756754

0 commit comments

Comments
 (0)