Skip to content

Commit 109988f

Browse files
pksunkaragitster
authored andcommitted
gitweb: fix esc_url
Earlier, 452e225 (gitweb: fix esc_param, 2009-10-13) fixed CGI escaping rules used in esc_url. A very similar logic exists in esc_param and needs to be fixed the same way. Signed-off-by: Pavan Kumar Sunkara <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1b79d1c commit 109988f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

gitweb/gitweb.perl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1173,8 +1173,7 @@ sub esc_param {
11731173
sub esc_url {
11741174
my $str = shift;
11751175
return undef unless defined $str;
1176-
$str =~ s/([^A-Za-z0-9\-_.~();\/;?:@&=])/sprintf("%%%02X", ord($1))/eg;
1177-
$str =~ s/\+/%2B/g;
1176+
$str =~ s/([^A-Za-z0-9\-_.~();\/;?:@&= ]+)/CGI::escape($1)/eg;
11781177
$str =~ s/ /\+/g;
11791178
return $str;
11801179
}

0 commit comments

Comments
 (0)