Skip to content

Commit 10ffca7

Browse files
Martin von Zweigbergkgitster
authored andcommitted
rebase: read state outside loop
The 'onto_name' state used in 'git rebase --merge' is currently read once for each commit that need to be applied. It doesn't change between each iteration, however, so it should be moved out of the loop. This also makes the code more readable. Also remove the unused variable 'end'. Signed-off-by: Martin von Zweigbergk <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 02ac45f commit 10ffca7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

git-rebase.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ read_state () {
6262
then
6363
state_dir="$merge_dir"
6464
prev_head=$(cat "$merge_dir"/prev_head) &&
65+
onto_name=$(cat "$merge_dir"/onto_name) &&
6566
end=$(cat "$merge_dir"/end) &&
6667
msgnum=$(cat "$merge_dir"/msgnum)
6768
else
@@ -123,9 +124,8 @@ call_merge () {
123124
hd=$(git rev-parse --verify HEAD)
124125
cmt_name=$(git symbolic-ref HEAD 2> /dev/null || echo HEAD)
125126
msgnum=$(cat "$merge_dir/msgnum")
126-
end=$(cat "$merge_dir/end")
127127
eval GITHEAD_$cmt='"${cmt_name##refs/heads/}~$(($end - $msgnum))"'
128-
eval GITHEAD_$hd='$(cat "$merge_dir/onto_name")'
128+
eval GITHEAD_$hd='$onto_name'
129129
export GITHEAD_$cmt GITHEAD_$hd
130130
if test -n "$GIT_QUIET"
131131
then

0 commit comments

Comments
 (0)