Skip to content

Commit 12f5eb9

Browse files
committed
Merge branch 'sg/commit-graph-progress-fix' into master
The code to produce progress output from "git commit-graph --write" had a few breakages, which have been fixed. * sg/commit-graph-progress-fix: commit-graph: fix "Writing out commit graph" progress counter commit-graph: fix progress of reachable commits
2 parents 05920f0 + 150cd3b commit 12f5eb9

File tree

1 file changed

+5
-22
lines changed

1 file changed

+5
-22
lines changed

commit-graph.c

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1149,23 +1149,14 @@ static void write_graph_chunk_bloom_indexes(struct hashfile *f,
11491149
struct commit **list = ctx->commits.list;
11501150
struct commit **last = ctx->commits.list + ctx->commits.nr;
11511151
uint32_t cur_pos = 0;
1152-
struct progress *progress = NULL;
1153-
int i = 0;
1154-
1155-
if (ctx->report_progress)
1156-
progress = start_delayed_progress(
1157-
_("Writing changed paths Bloom filters index"),
1158-
ctx->commits.nr);
11591152

11601153
while (list < last) {
11611154
struct bloom_filter *filter = get_bloom_filter(ctx->r, *list, 0);
11621155
cur_pos += filter->len;
1163-
display_progress(progress, ++i);
1156+
display_progress(ctx->progress, ++ctx->progress_cnt);
11641157
hashwrite_be32(f, cur_pos);
11651158
list++;
11661159
}
1167-
1168-
stop_progress(&progress);
11691160
}
11701161

11711162
static void write_graph_chunk_bloom_data(struct hashfile *f,
@@ -1174,26 +1165,17 @@ static void write_graph_chunk_bloom_data(struct hashfile *f,
11741165
{
11751166
struct commit **list = ctx->commits.list;
11761167
struct commit **last = ctx->commits.list + ctx->commits.nr;
1177-
struct progress *progress = NULL;
1178-
int i = 0;
1179-
1180-
if (ctx->report_progress)
1181-
progress = start_delayed_progress(
1182-
_("Writing changed paths Bloom filters data"),
1183-
ctx->commits.nr);
11841168

11851169
hashwrite_be32(f, settings->hash_version);
11861170
hashwrite_be32(f, settings->num_hashes);
11871171
hashwrite_be32(f, settings->bits_per_entry);
11881172

11891173
while (list < last) {
11901174
struct bloom_filter *filter = get_bloom_filter(ctx->r, *list, 0);
1191-
display_progress(progress, ++i);
1175+
display_progress(ctx->progress, ++ctx->progress_cnt);
11921176
hashwrite(f, filter->data, filter->len * sizeof(unsigned char));
11931177
list++;
11941178
}
1195-
1196-
stop_progress(&progress);
11971179
}
11981180

11991181
static int oid_compare(const void *_a, const void *_b)
@@ -1423,12 +1405,13 @@ int write_commit_graph_reachable(struct object_directory *odb,
14231405
_("Collecting referenced commits"), 0);
14241406

14251407
for_each_ref(add_ref_to_set, &data);
1408+
1409+
stop_progress(&data.progress);
1410+
14261411
result = write_commit_graph(odb, NULL, &commits,
14271412
flags, split_opts);
14281413

14291414
oidset_clear(&commits);
1430-
if (data.progress)
1431-
stop_progress(&data.progress);
14321415
return result;
14331416
}
14341417

0 commit comments

Comments
 (0)