Skip to content

Commit 131b8fc

Browse files
peffgitster
authored andcommitted
fetch: run gc --auto after fetching
We generally try to run "gc --auto" after any commands that might introduce a large number of new objects. An obvious place to do so is after running "fetch", which may introduce new loose objects or packs (depending on the size of the fetch). While an active developer repository will probably eventually trigger a "gc --auto" on another action (e.g., git-rebase), there are two good reasons why it is nicer to do it at fetch time: 1. Read-only repositories which track an upstream (e.g., a continuous integration server which fetches and builds, but never makes new commits) will accrue loose objects and small packs, but never coalesce them into a more efficient larger pack. 2. Fetching is often already perceived to be slow to the user, since they have to wait on the network. It's much more pleasant to include a potentially slow auto-gc as part of the already-long network fetch than in the middle of productive work with git-rebase or similar. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 7e20105 commit 131b8fc

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

builtin/fetch.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -960,6 +960,9 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
960960
struct string_list list = STRING_LIST_INIT_NODUP;
961961
struct remote *remote;
962962
int result = 0;
963+
static const char *argv_gc_auto[] = {
964+
"gc", "--auto", NULL,
965+
};
963966

964967
packet_trace_identity("fetch");
965968

@@ -1027,5 +1030,7 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
10271030
list.strdup_strings = 1;
10281031
string_list_clear(&list, 0);
10291032

1033+
run_command_v_opt(argv_gc_auto, RUN_GIT_CMD);
1034+
10301035
return result;
10311036
}

0 commit comments

Comments
 (0)