Skip to content

Commit 14332bc

Browse files
ashumkingitster
authored andcommitted
t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1
Both "iso8859-1" and "iso-8859-1" are understood as latin-1 by modern platforms, but the latter is not understood by older platforms;update tests to use the former. This is in line with 3994e8a (t4201: use ISO8859-1 rather than ISO-8859-1, 2009-12-03), which did the same. Signed-off-by: Alexey Shumkin <[email protected]> Reviewed-by: Johannes Sixt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 7c37521 commit 14332bc

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

t/t4041-diff-submodule-option.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ add_file () {
2323
echo "$name" >"$name" &&
2424
git add "$name" &&
2525
test_tick &&
26-
msg_added_iso88591=$(echo "Add $name ($added $name)" | iconv -f utf-8 -t iso-8859-1) &&
27-
git -c 'i18n.commitEncoding=iso-8859-1' commit -m "$msg_added_iso88591"
26+
msg_added_iso88591=$(echo "Add $name ($added $name)" | iconv -f utf-8 -t iso8859-1) &&
27+
git -c 'i18n.commitEncoding=iso8859-1' commit -m "$msg_added_iso88591"
2828
done >/dev/null &&
2929
git rev-parse --short --verify HEAD
3030
)

t/t4205-log-pretty-formats.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ test_expect_success 'set up basic repos' '
3232
>bar &&
3333
git add foo &&
3434
test_tick &&
35-
git config i18n.commitEncoding iso-8859-1 &&
36-
git commit -m "$(commit_msg iso-8859-1)" &&
35+
git config i18n.commitEncoding iso8859-1 &&
36+
git commit -m "$(commit_msg iso8859-1)" &&
3737
git add bar &&
3838
test_tick &&
3939
git commit -m "add bar" &&
@@ -61,8 +61,8 @@ test_expect_success 'alias user-defined format' '
6161
test_cmp expected actual
6262
'
6363

64-
test_expect_success 'alias user-defined tformat with %s (iso-8859-1 encoding)' '
65-
git config i18n.logOutputEncoding iso-8859-1 &&
64+
test_expect_success 'alias user-defined tformat with %s (iso8859-1 encoding)' '
65+
git config i18n.logOutputEncoding iso8859-1 &&
6666
git log --oneline >expected-s &&
6767
git log --pretty="tformat:%h %s" >actual-s &&
6868
git config --unset i18n.logOutputEncoding &&

t/t6006-rev-list-format.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ test_tick
1212
# String "added" in German (translated with Google Translate), encoded in UTF-8,
1313
# used as a commit log message below.
1414
added=$(printf "added (hinzugef\303\274gt) foo")
15-
added_iso88591=$(echo "$added" | iconv -f utf-8 -t iso-8859-1)
15+
added_iso88591=$(echo "$added" | iconv -f utf-8 -t iso8859-1)
1616
# same but "changed"
1717
changed=$(printf "changed (ge\303\244ndert) foo")
18-
changed_iso88591=$(echo "$changed" | iconv -f utf-8 -t iso-8859-1)
18+
changed_iso88591=$(echo "$changed" | iconv -f utf-8 -t iso8859-1)
1919

2020
test_expect_success 'setup' '
2121
: >foo &&
2222
git add foo &&
23-
git config i18n.commitEncoding iso-8859-1 &&
23+
git config i18n.commitEncoding iso8859-1 &&
2424
git commit -m "$added_iso88591" &&
2525
head1=$(git rev-parse --verify HEAD) &&
2626
head1_short=$(git rev-parse --verify --short $head1) &&
@@ -136,9 +136,9 @@ EOF
136136

137137
test_format encoding %e <<EOF
138138
commit $head2
139-
iso-8859-1
139+
iso8859-1
140140
commit $head1
141-
iso-8859-1
141+
iso8859-1
142142
EOF
143143

144144
test_format subject %s <<EOF
@@ -242,9 +242,9 @@ test_format complex-encoding %e <<EOF
242242
commit $head3
243243
iso8859-1
244244
commit $head2
245-
iso-8859-1
245+
iso8859-1
246246
commit $head1
247-
iso-8859-1
247+
iso8859-1
248248
EOF
249249

250250
test_format complex-subject %s <<EOF

t/t7102-reset.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ test_expect_success 'creating initial files and commits' '
3939
4040
echo "1st line 2nd file" >secondfile &&
4141
echo "2nd line 2nd file" >>secondfile &&
42-
git -c "i18n.commitEncoding=iso-8859-1" commit -a -m "$(commit_msg iso-8859-1)" &&
42+
git -c "i18n.commitEncoding=iso8859-1" commit -a -m "$(commit_msg iso8859-1)" &&
4343
head5=$(git rev-parse --verify HEAD)
4444
'
4545
# git log --pretty=oneline # to see those SHA1 involved
@@ -62,10 +62,10 @@ test_expect_success 'reset --hard message' '
6262
test_cmp .expected .actual
6363
'
6464

65-
test_expect_success 'reset --hard message (iso-8859-1 logoutencoding)' '
65+
test_expect_success 'reset --hard message (iso8859-1 logoutputencoding)' '
6666
hex=$(git log -1 --format="%h") &&
67-
git -c "i18n.logOutputEncoding=iso-8859-1" reset --hard > .actual &&
68-
echo HEAD is now at $hex $(commit_msg iso-8859-1) > .expected &&
67+
git -c "i18n.logOutputEncoding=iso8859-1" reset --hard > .actual &&
68+
echo HEAD is now at $hex $(commit_msg iso8859-1) > .expected &&
6969
test_cmp .expected .actual
7070
'
7171

@@ -329,7 +329,7 @@ test_expect_success 'redoing the last two commits should succeed' '
329329
330330
echo "1st line 2nd file" >secondfile &&
331331
echo "2nd line 2nd file" >>secondfile &&
332-
git -c "i18n.commitEncoding=iso-8859-1" commit -a -m "$(commit_msg iso-8859-1)" &&
332+
git -c "i18n.commitEncoding=iso8859-1" commit -a -m "$(commit_msg iso8859-1)" &&
333333
check_changes $head5
334334
'
335335

0 commit comments

Comments
 (0)