test: rev-parse-upstream: add missing cmp

felipec · gitster · commit 159f4b9c3b9c · 2023-05-09T09:25:53.000-07:00
It seems pretty clear 5236fce (t1507: stop losing return codes of git commands, 2019-12-20) missed a test_cmp. Cc: Denton Liu <liu.denton@gmail.com> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/t/t1507-rev-parse-upstream.sh b/t/t1507-rev-parse-upstream.sh
@@ -97,7 +97,8 @@ test_expect_success 'my-side@{u} resolves to correct commit' '
 	commit_subject my-side >actual &&
 	test_cmp expect actual &&
 	echo 5 >expect &&
-	commit_subject my-side@{u} >actual
+	commit_subject my-side@{u} >actual &&
+	test_cmp expect actual
 '
 
 test_expect_success 'not-tracking@{u} fails' '

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,8 @@ test_expect_success 'my-side@{u} resolves to correct commit' '`
`97`	`97`	`commit_subject my-side >actual &&`
`98`	`98`	`test_cmp expect actual &&`
`99`	`99`	`echo 5 >expect &&`
`100`		`- commit_subject my-side@{u} >actual`
	`100`	`+ commit_subject my-side@{u} >actual &&`
	`101`	`+ test_cmp expect actual`
`101`	`102`	`'`
`102`	`103`
`103`	`104`	`test_expect_success 'not-tracking@{u} fails' '`