Skip to content

Commit 1616898

Browse files
Pete Wyckoffgitster
authored andcommitted
git p4 test: wildcards are supported
Since 9d57c4a (git p4: implement view spec wildcards with "p4 where", 2013-08-30), all the wildcard types should be supported. Change must-fail tests to mark that they now pass. Signed-off-by: Pete Wyckoff <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent feb28ad commit 1616898

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

t/t9809-git-p4-client-view.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,28 +76,28 @@ test_expect_success 'init depot' '
7676
'
7777

7878
# double % for printf
79-
test_expect_success 'unsupported view wildcard %%n' '
79+
test_expect_success 'view wildcard %%n' '
8080
client_view "//depot/%%%%1/sub/... //client/sub/%%%%1/..." &&
8181
test_when_finished cleanup_git &&
82-
test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
82+
git p4 clone --use-client-spec --dest="$git" //depot
8383
'
8484

85-
test_expect_success 'unsupported view wildcard *' '
85+
test_expect_success 'view wildcard *' '
8686
client_view "//depot/*/bar/... //client/*/bar/..." &&
8787
test_when_finished cleanup_git &&
88-
test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
88+
git p4 clone --use-client-spec --dest="$git" //depot
8989
'
9090

91-
test_expect_success 'wildcard ... only supported at end of spec 1' '
91+
test_expect_success 'wildcard ... in the middle' '
9292
client_view "//depot/.../file11 //client/.../file11" &&
9393
test_when_finished cleanup_git &&
94-
test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
94+
git p4 clone --use-client-spec --dest="$git" //depot
9595
'
9696

97-
test_expect_success 'wildcard ... only supported at end of spec 2' '
97+
test_expect_success 'wildcard ... in the middle and at the end' '
9898
client_view "//depot/.../a/... //client/.../a/..." &&
9999
test_when_finished cleanup_git &&
100-
test_must_fail git p4 clone --use-client-spec --dest="$git" //depot
100+
git p4 clone --use-client-spec --dest="$git" //depot
101101
'
102102

103103
test_expect_success 'basic map' '

0 commit comments

Comments
 (0)