Merge branch 'cp/sideband-array-index-comment-fix' into maint-2.43

gitster · gitster · commit 16a830f6c2be · 2024-02-08T16:22:12.000-08:00
In-code comment fix.

* cp/sideband-array-index-comment-fix:
  sideband.c: remove redundant 'NEEDSWORK' tag
diff --git a/sideband.c b/sideband.c
@@ -69,7 +69,10 @@ void list_config_color_sideband_slots(struct string_list *list, const char *pref
  * of the line. This should be called for a single line only, which is
  * passed as the first N characters of the SRC array.
  *
- * NEEDSWORK: use "size_t n" instead for clarity.
+ * It is fine to use "int n" here instead of "size_t n" as all calls to this
+ * function pass an 'int' parameter. Additionally, the buffer involved in
+ * storing these 'int' values takes input from a packet via the pkt-line
+ * interface, which is capable of transferring only 64kB at a time.
  */
 static void maybe_colorize_sideband(struct strbuf *dest, const char *src, int n)
 {

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,10 @@ void list_config_color_sideband_slots(struct string_list list, const char pref`
`69`	`69`	`* of the line. This should be called for a single line only, which is`
`70`	`70`	`* passed as the first N characters of the SRC array.`
`71`	`71`	`*`
`72`		`- * NEEDSWORK: use "size_t n" instead for clarity.`
	`72`	`+ * It is fine to use "int n" here instead of "size_t n" as all calls to this`
	`73`	`+ * function pass an 'int' parameter. Additionally, the buffer involved in`
	`74`	`+ * storing these 'int' values takes input from a packet via the pkt-line`
	`75`	`+ * interface, which is capable of transferring only 64kB at a time.`
`73`	`76`	`*/`
`74`	`77`	`static void maybe_colorize_sideband(struct strbuf dest, const char src, int n)`
`75`	`78`	`{`