Skip to content

Commit 1793280

Browse files
ttaylorrgitster
authored andcommitted
t5318: don't pass non-object directory to '--object-dir'
In f237c8b (commit-graph: implement git-commit-graph write, 2018-04-02) the test t5318.3 was introduced to ensure that calling 'git commit-graph write' in a repository with no packfiles does not write any commit-graph file(s). To exercise more paths in 'builtin/commit-graph.c', this test passes '--object-dir' to 'git commit-graph write', but the given argument refers to the working copy, not the object directory. Since the commit-graph sub-commands currently swallow these errors, this does not result in a test failure. But, it is only lucky that the test ends with no commit-graphs, since there were none to begin with. In preparation for a future commit where an '--object-dir' argument that does not match a known object directory will print out a failure, let's fix the test to still use '--object-dir', but pass the correct location to the object store instead of '.'. Signed-off-by: Taylor Blau <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d0654dc commit 1793280

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/t5318-commit-graph.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ test_expect_success 'verify graph with no graph file' '
1919

2020
test_expect_success 'write graph with no packs' '
2121
cd "$TRASH_DIRECTORY/full" &&
22-
git commit-graph write --object-dir . &&
23-
test_path_is_missing info/commit-graph
22+
git commit-graph write --object-dir $objdir &&
23+
test_path_is_missing $objdir/info/commit-graph
2424
'
2525

2626
test_expect_success 'exit with correct error on bad input to --stdin-packs' '

0 commit comments

Comments
 (0)