Skip to content

Commit 18fe5ad

Browse files
drafnelgitster
authored andcommitted
contrib/git-credential-gnome-keyring.c: add static where applicable
Mark global variable and functions as static. Signed-off-by: Brandon Casey <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 4bc47cc commit 18fe5ad

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

contrib/credential/gnome-keyring/git-credential-gnome-keyring.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ static char* keyring_object(struct credential *c)
128128
return object;
129129
}
130130

131-
int keyring_get(struct credential *c)
131+
static int keyring_get(struct credential *c)
132132
{
133133
char* object = NULL;
134134
GList *entries;
@@ -178,7 +178,7 @@ int keyring_get(struct credential *c)
178178
}
179179

180180

181-
int keyring_store(struct credential *c)
181+
static int keyring_store(struct credential *c)
182182
{
183183
guint32 item_id;
184184
char *object = NULL;
@@ -212,7 +212,7 @@ int keyring_store(struct credential *c)
212212
return EXIT_SUCCESS;
213213
}
214214

215-
int keyring_erase(struct credential *c)
215+
static int keyring_erase(struct credential *c)
216216
{
217217
char *object = NULL;
218218
GList *entries;
@@ -277,7 +277,7 @@ int keyring_erase(struct credential *c)
277277
* Table with helper operation callbacks, used by generic
278278
* credential helper main function.
279279
*/
280-
struct credential_operation const credential_helper_ops[] =
280+
static struct credential_operation const credential_helper_ops[] =
281281
{
282282
{ "get", keyring_get },
283283
{ "store", keyring_store },
@@ -287,12 +287,12 @@ struct credential_operation const credential_helper_ops[] =
287287

288288
/* ------------------ credential functions ------------------ */
289289

290-
void credential_init(struct credential *c)
290+
static void credential_init(struct credential *c)
291291
{
292292
memset(c, 0, sizeof(*c));
293293
}
294294

295-
void credential_clear(struct credential *c)
295+
static void credential_clear(struct credential *c)
296296
{
297297
free(c->protocol);
298298
free(c->host);
@@ -303,7 +303,7 @@ void credential_clear(struct credential *c)
303303
credential_init(c);
304304
}
305305

306-
int credential_read(struct credential *c)
306+
static int credential_read(struct credential *c)
307307
{
308308
char buf[1024];
309309
ssize_t line_len = 0;
@@ -358,14 +358,14 @@ int credential_read(struct credential *c)
358358
return 0;
359359
}
360360

361-
void credential_write_item(FILE *fp, const char *key, const char *value)
361+
static void credential_write_item(FILE *fp, const char *key, const char *value)
362362
{
363363
if (!value)
364364
return;
365365
fprintf(fp, "%s=%s\n", key, value);
366366
}
367367

368-
void credential_write(const struct credential *c)
368+
static void credential_write(const struct credential *c)
369369
{
370370
/* only write username/password, if set */
371371
credential_write_item(stdout, "username", c->username);

0 commit comments

Comments
 (0)