Skip to content

Commit 1a812f3

Browse files
Ingo Molnargitster
authored andcommitted
hashcmp(): inline memcmp() by hand to optimize
This is reported to speed "git gc" by 18%. Signed-off-by: Ingo Molnar <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent e923eae commit 1a812f3

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

cache.h

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -614,14 +614,24 @@ extern char *sha1_pack_name(const unsigned char *sha1);
614614
extern char *sha1_pack_index_name(const unsigned char *sha1);
615615
extern const char *find_unique_abbrev(const unsigned char *sha1, int);
616616
extern const unsigned char null_sha1[20];
617-
static inline int is_null_sha1(const unsigned char *sha1)
617+
618+
static inline int hashcmp(const unsigned char *sha1, const unsigned char *sha2)
618619
{
619-
return !memcmp(sha1, null_sha1, 20);
620+
int i;
621+
622+
for (i = 0; i < 20; i++, sha1++, sha2++) {
623+
if (*sha1 != *sha2)
624+
return *sha1 - *sha2;
625+
}
626+
627+
return 0;
620628
}
621-
static inline int hashcmp(const unsigned char *sha1, const unsigned char *sha2)
629+
630+
static inline int is_null_sha1(const unsigned char *sha1)
622631
{
623-
return memcmp(sha1, sha2, 20);
632+
return !hashcmp(sha1, null_sha1);
624633
}
634+
625635
static inline void hashcpy(unsigned char *sha_dst, const unsigned char *sha_src)
626636
{
627637
memcpy(sha_dst, sha_src, 20);

0 commit comments

Comments
 (0)