Skip to content

Commit 1a9a23e

Browse files
johnkeepinggitster
authored andcommitted
t7610: don't use test_config in a subshell
test_config uses test_when_finished to reset the configuration after the test, but this does not work inside a subshell. This does not cause a problem here because the first thing the next test does is to set this config variable itself, but we are about to add a check that will complain when test_when_finished is used in a subshell. In this case, "subdir" not a submodule so test_config has the same effect when run at the top level and can simply be moved out of the subshell. Signed-off-by: John Keeping <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent fb8880d commit 1a9a23e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t7610-mergetool.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,9 +174,9 @@ test_expect_success 'mergetool skips autoresolved' '
174174
'
175175

176176
test_expect_success 'mergetool merges all from subdir' '
177+
test_config rerere.enabled false &&
177178
(
178179
cd subdir &&
179-
test_config rerere.enabled false &&
180180
test_must_fail git merge master &&
181181
( yes "r" | git mergetool ../submod ) &&
182182
( yes "d" "d" | git mergetool --no-prompt ) &&

0 commit comments

Comments
 (0)