Skip to content

Commit 1acc1e9

Browse files
committed
fixup! t3903: modernize style
In preparation for a newer patch series. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 0e1bf9f commit 1acc1e9

File tree

1 file changed

+59
-61
lines changed

1 file changed

+59
-61
lines changed

t/t3903-stash.sh

Lines changed: 59 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,22 @@ test_description='Test git stash'
88
. ./test-lib.sh
99

1010
test_expect_success 'stash some dirty working directory' '
11-
echo 1 >file &&
11+
echo 1 > file &&
1212
git add file &&
1313
echo unrelated >other-file &&
1414
git add other-file &&
1515
test_tick &&
1616
git commit -m initial &&
17-
echo 2 >file &&
17+
echo 2 > file &&
1818
git add file &&
19-
echo 3 >file &&
19+
echo 3 > file &&
2020
test_tick &&
2121
git stash &&
2222
git diff-files --quiet &&
2323
git diff-index --cached --quiet HEAD
2424
'
2525

26-
cat >expect <<EOF
26+
cat > expect << EOF
2727
diff --git a/file b/file
2828
index 0cfbf08..00750ed 100644
2929
--- a/file
@@ -35,7 +35,7 @@ EOF
3535

3636
test_expect_success 'parents of stash' '
3737
test $(git rev-parse stash^) = $(git rev-parse HEAD) &&
38-
git diff stash^2..stash >output &&
38+
git diff stash^2..stash > output &&
3939
test_cmp expect output
4040
'
4141

@@ -74,7 +74,7 @@ test_expect_success 'apply stashed changes' '
7474

7575
test_expect_success 'apply stashed changes (including index)' '
7676
git reset --hard HEAD^ &&
77-
echo 6 >other-file &&
77+
echo 6 > other-file &&
7878
git add other-file &&
7979
test_tick &&
8080
git commit -m other-file &&
@@ -99,12 +99,12 @@ test_expect_success 'stash drop complains of extra options' '
9999

100100
test_expect_success 'drop top stash' '
101101
git reset --hard &&
102-
git stash list >expected &&
103-
echo 7 >file &&
102+
git stash list > stashlist1 &&
103+
echo 7 > file &&
104104
git stash &&
105105
git stash drop &&
106-
git stash list >actual &&
107-
test_cmp expected actual &&
106+
git stash list > stashlist2 &&
107+
test_cmp stashlist1 stashlist2 &&
108108
git stash apply &&
109109
test 3 = $(cat file) &&
110110
test 1 = $(git show :file) &&
@@ -113,9 +113,9 @@ test_expect_success 'drop top stash' '
113113

114114
test_expect_success 'drop middle stash' '
115115
git reset --hard &&
116-
echo 8 >file &&
116+
echo 8 > file &&
117117
git stash &&
118-
echo 9 >file &&
118+
echo 9 > file &&
119119
git stash &&
120120
git stash drop stash@{1} &&
121121
test 2 = $(git stash list | wc -l) &&
@@ -160,7 +160,7 @@ test_expect_success 'stash pop' '
160160
test 0 = $(git stash list | wc -l)
161161
'
162162

163-
cat >expect <<EOF
163+
cat > expect << EOF
164164
diff --git a/file2 b/file2
165165
new file mode 100644
166166
index 0000000..1fe912c
@@ -170,7 +170,7 @@ index 0000000..1fe912c
170170
+bar2
171171
EOF
172172

173-
cat >expect1 <<EOF
173+
cat > expect1 << EOF
174174
diff --git a/file b/file
175175
index 257cc56..5716ca5 100644
176176
--- a/file
@@ -180,7 +180,7 @@ index 257cc56..5716ca5 100644
180180
+bar
181181
EOF
182182

183-
cat >expect2 <<EOF
183+
cat > expect2 << EOF
184184
diff --git a/file b/file
185185
index 7601807..5716ca5 100644
186186
--- a/file
@@ -198,79 +198,79 @@ index 0000000..1fe912c
198198
EOF
199199

200200
test_expect_success 'stash branch' '
201-
echo foo >file &&
201+
echo foo > file &&
202202
git commit file -m first &&
203-
echo bar >file &&
204-
echo bar2 >file2 &&
203+
echo bar > file &&
204+
echo bar2 > file2 &&
205205
git add file2 &&
206206
git stash &&
207-
echo baz >file &&
207+
echo baz > file &&
208208
git commit file -m second &&
209209
git stash branch stashbranch &&
210210
test refs/heads/stashbranch = $(git symbolic-ref HEAD) &&
211211
test $(git rev-parse HEAD) = $(git rev-parse master^) &&
212-
git diff --cached >output &&
212+
git diff --cached > output &&
213213
test_cmp expect output &&
214-
git diff >output &&
214+
git diff > output &&
215215
test_cmp expect1 output &&
216216
git add file &&
217217
git commit -m alternate\ second &&
218-
git diff master..stashbranch >output &&
218+
git diff master..stashbranch > output &&
219219
test_cmp output expect2 &&
220220
test 0 = $(git stash list | wc -l)
221221
'
222222

223223
test_expect_success 'apply -q is quiet' '
224-
echo foo >file &&
224+
echo foo > file &&
225225
git stash &&
226-
git stash apply -q >output.out 2>&1 &&
226+
git stash apply -q > output.out 2>&1 &&
227227
test_must_be_empty output.out
228228
'
229229

230230
test_expect_success 'save -q is quiet' '
231-
git stash save --quiet >output.out 2>&1 &&
231+
git stash save --quiet > output.out 2>&1 &&
232232
test_must_be_empty output.out
233233
'
234234

235235
test_expect_success 'pop -q is quiet' '
236-
git stash pop -q >output.out 2>&1 &&
236+
git stash pop -q > output.out 2>&1 &&
237237
test_must_be_empty output.out
238238
'
239239

240240
test_expect_success 'pop -q --index works and is quiet' '
241-
echo foo >file &&
241+
echo foo > file &&
242242
git add file &&
243243
git stash save --quiet &&
244-
git stash pop -q --index >output.out 2>&1 &&
244+
git stash pop -q --index > output.out 2>&1 &&
245245
test foo = "$(git show :file)" &&
246246
test_must_be_empty output.out
247247
'
248248

249249
test_expect_success 'drop -q is quiet' '
250250
git stash &&
251-
git stash drop -q >output.out 2>&1 &&
251+
git stash drop -q > output.out 2>&1 &&
252252
test_must_be_empty output.out
253253
'
254254

255255
test_expect_success 'stash -k' '
256-
echo bar3 >file &&
257-
echo bar4 >file2 &&
256+
echo bar3 > file &&
257+
echo bar4 > file2 &&
258258
git add file2 &&
259259
git stash -k &&
260260
test bar,bar4 = $(cat file),$(cat file2)
261261
'
262262

263263
test_expect_success 'stash --no-keep-index' '
264-
echo bar33 >file &&
265-
echo bar44 >file2 &&
264+
echo bar33 > file &&
265+
echo bar44 > file2 &&
266266
git add file2 &&
267267
git stash --no-keep-index &&
268268
test bar,bar2 = $(cat file),$(cat file2)
269269
'
270270

271271
test_expect_success 'stash --invalid-option' '
272-
echo bar5 >file &&
273-
echo bar6 >file2 &&
272+
echo bar5 > file &&
273+
echo bar6 > file2 &&
274274
git add file2 &&
275275
test_must_fail git stash --invalid-option &&
276276
test_must_fail git stash save --invalid-option &&
@@ -486,28 +486,26 @@ test_expect_success 'stash branch - no stashes on stack, stash-like argument' '
486486
git stash clear &&
487487
test_when_finished "git reset --hard HEAD" &&
488488
git reset --hard &&
489-
echo foo >>file &&
489+
echo foo >> file &&
490490
STASH_ID=$(git stash create) &&
491491
git reset --hard &&
492492
git stash branch stash-branch ${STASH_ID} &&
493-
test_when_finished "git reset --hard HEAD && git checkout master &&
494-
git branch -D stash-branch" &&
493+
test_when_finished "git reset --hard HEAD && git checkout master && git branch -D stash-branch" &&
495494
test $(git ls-files --modified | wc -l) -eq 1
496495
'
497496

498497
test_expect_success 'stash branch - stashes on stack, stash-like argument' '
499498
git stash clear &&
500499
test_when_finished "git reset --hard HEAD" &&
501500
git reset --hard &&
502-
echo foo >>file &&
501+
echo foo >> file &&
503502
git stash &&
504503
test_when_finished "git stash drop" &&
505-
echo bar >>file &&
504+
echo bar >> file &&
506505
STASH_ID=$(git stash create) &&
507506
git reset --hard &&
508507
git stash branch stash-branch ${STASH_ID} &&
509-
test_when_finished "git reset --hard HEAD && git checkout master &&
510-
git branch -D stash-branch" &&
508+
test_when_finished "git reset --hard HEAD && git checkout master && git branch -D stash-branch" &&
511509
test $(git ls-files --modified | wc -l) -eq 1
512510
'
513511

@@ -520,10 +518,10 @@ test_expect_success 'stash show format defaults to --stat' '
520518
git stash clear &&
521519
test_when_finished "git reset --hard HEAD" &&
522520
git reset --hard &&
523-
echo foo >>file &&
521+
echo foo >> file &&
524522
git stash &&
525523
test_when_finished "git stash drop" &&
526-
echo bar >>file &&
524+
echo bar >> file &&
527525
STASH_ID=$(git stash create) &&
528526
git reset --hard &&
529527
cat >expected <<-EOF &&
@@ -538,10 +536,10 @@ test_expect_success 'stash show - stashes on stack, stash-like argument' '
538536
git stash clear &&
539537
test_when_finished "git reset --hard HEAD" &&
540538
git reset --hard &&
541-
echo foo >>file &&
539+
echo foo >> file &&
542540
git stash &&
543541
test_when_finished "git stash drop" &&
544-
echo bar >>file &&
542+
echo bar >> file &&
545543
STASH_ID=$(git stash create) &&
546544
git reset --hard &&
547545
echo "1 0 file" >expected &&
@@ -553,10 +551,10 @@ test_expect_success 'stash show -p - stashes on stack, stash-like argument' '
553551
git stash clear &&
554552
test_when_finished "git reset --hard HEAD" &&
555553
git reset --hard &&
556-
echo foo >>file &&
554+
echo foo >> file &&
557555
git stash &&
558556
test_when_finished "git stash drop" &&
559-
echo bar >>file &&
557+
echo bar >> file &&
560558
STASH_ID=$(git stash create) &&
561559
git reset --hard &&
562560
cat >expected <<-EOF &&
@@ -576,7 +574,7 @@ test_expect_success 'stash show - no stashes on stack, stash-like argument' '
576574
git stash clear &&
577575
test_when_finished "git reset --hard HEAD" &&
578576
git reset --hard &&
579-
echo foo >>file &&
577+
echo foo >> file &&
580578
STASH_ID=$(git stash create) &&
581579
git reset --hard &&
582580
echo "1 0 file" >expected &&
@@ -588,7 +586,7 @@ test_expect_success 'stash show -p - no stashes on stack, stash-like argument' '
588586
git stash clear &&
589587
test_when_finished "git reset --hard HEAD" &&
590588
git reset --hard &&
591-
echo foo >>file &&
589+
echo foo >> file &&
592590
STASH_ID=$(git stash create) &&
593591
git reset --hard &&
594592
cat >expected <<-EOF &&
@@ -608,9 +606,9 @@ test_expect_success 'stash drop - fail early if specified stash is not a stash r
608606
git stash clear &&
609607
test_when_finished "git reset --hard HEAD && git stash clear" &&
610608
git reset --hard &&
611-
echo foo >file &&
609+
echo foo > file &&
612610
git stash &&
613-
echo bar >file &&
611+
echo bar > file &&
614612
git stash &&
615613
test_must_fail git stash drop $(git rev-parse stash@{0}) &&
616614
git stash pop &&
@@ -622,9 +620,9 @@ test_expect_success 'stash pop - fail early if specified stash is not a stash re
622620
git stash clear &&
623621
test_when_finished "git reset --hard HEAD && git stash clear" &&
624622
git reset --hard &&
625-
echo foo >file &&
623+
echo foo > file &&
626624
git stash &&
627-
echo bar >file &&
625+
echo bar > file &&
628626
git stash &&
629627
test_must_fail git stash pop $(git rev-parse stash@{0}) &&
630628
git stash pop &&
@@ -634,8 +632,8 @@ test_expect_success 'stash pop - fail early if specified stash is not a stash re
634632

635633
test_expect_success 'ref with non-existent reflog' '
636634
git stash clear &&
637-
echo bar5 >file &&
638-
echo bar6 >file2 &&
635+
echo bar5 > file &&
636+
echo bar6 > file2 &&
639637
git add file2 &&
640638
git stash &&
641639
test_must_fail git rev-parse --quiet --verify does-not-exist &&
@@ -655,8 +653,8 @@ test_expect_success 'ref with non-existent reflog' '
655653
test_expect_success 'invalid ref of the form stash@{n}, n >= N' '
656654
git stash clear &&
657655
test_must_fail git stash drop stash@{0} &&
658-
echo bar5 >file &&
659-
echo bar6 >file2 &&
656+
echo bar5 > file &&
657+
echo bar6 > file2 &&
660658
git add file2 &&
661659
git stash &&
662660
test_must_fail git stash drop stash@{1} &&
@@ -726,7 +724,7 @@ test_expect_success 'stash apply shows status same as git status (relative to cu
726724
test_i18ncmp expect actual
727725
'
728726

729-
cat >expect <<EOF
727+
cat > expect << EOF
730728
diff --git a/HEAD b/HEAD
731729
new file mode 100644
732730
index 0000000..fe0cbee
@@ -739,14 +737,14 @@ EOF
739737
test_expect_success 'stash where working directory contains "HEAD" file' '
740738
git stash clear &&
741739
git reset --hard &&
742-
echo file-not-a-ref >HEAD &&
740+
echo file-not-a-ref > HEAD &&
743741
git add HEAD &&
744742
test_tick &&
745743
git stash &&
746744
git diff-files --quiet &&
747745
git diff-index --cached --quiet HEAD &&
748746
test "$(git rev-parse stash^)" = "$(git rev-parse HEAD)" &&
749-
git diff stash^..stash >output &&
747+
git diff stash^..stash > output &&
750748
test_cmp expect output
751749
'
752750

0 commit comments

Comments
 (0)