Skip to content

Commit 1bb207e

Browse files
committed
tests: drop GIT_*_TIMING_TESTS environment variable support
Two tests (t3302 and t3419) used to have their own environment variable to trigger expensive tests without enabling expensive tests in other scripts; a user could set GIT_NOTES_TIMING_TESTS but not GIT_TEST_LONG and run the whole test suite and trigger expensive tests only in t3302 but not other tests. The same for GIT_PATCHID_TIMING_TESTS in t3419. While this may have seemed a good flexibility, in reality if you are concentrating on a single test (e.g. t3302), you can just run that single test with the GIT_TEST_LONG to trigger expensive tests. It does not seem worth forcing other people who may want to come up with their own expensive tests to invent new environment variables by keeping this convention. Drop them. Signed-off-by: Junio C Hamano <[email protected]>
1 parent b687cd6 commit 1bb207e

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

t/t3302-notes-index-expensive.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ test_description='Test commit notes index (expensive!)'
77

88
. ./test-lib.sh
99

10-
test -n "$GIT_NOTES_TIMING_TESTS" && test_set_prereq EXPENSIVE
11-
1210
create_repo () {
1311
number_of_commits=$1
1412
nr=0

t/t3419-rebase-patch-id.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ test_description='git rebase - test patch id computation'
44

55
. ./test-lib.sh
66

7-
test -n "$GIT_PATCHID_TIMING_TESTS" && test_set_prereq EXPENSIVE
8-
97
count () {
108
i=0
119
while test $i -lt $1

0 commit comments

Comments
 (0)