Skip to content

Commit 1be36b6

Browse files
peffgitster
authored andcommitted
Makefile: drop extra dependencies for test helpers
A few test-helpers have Makefile dependencies on specific object files. But since these files are part of libgit.a (which all of the helpers link against), the inclusion is simply redundant. These were once necessary, but became redundant due to 5c5ba73 (Makefile: Use generic rule to build test programs, 2007-05-31), which added the $(GITLIBS) dependency (but didn't prune the extra dependency lines). Later commits then cargo-culted the practice (e.g., b4285c7). Note that we _do_ need to leave the dependencies on the svn library, as that is not part of the usual link command. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 2ec075d commit 1be36b6

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

Makefile

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2231,16 +2231,8 @@ perf: all
22312231

22322232
.PHONY: test perf
22332233

2234-
t/helper/test-ctype$X: ctype.o
2235-
2236-
t/helper/test-date$X: date.o ctype.o
2237-
2238-
t/helper/test-delta$X: diff-delta.o patch-delta.o
2239-
22402234
t/helper/test-line-buffer$X: vcs-svn/lib.a
22412235

2242-
t/helper/test-parse-options$X: parse-options.o parse-options-cb.o
2243-
22442236
t/helper/test-svn-fe$X: vcs-svn/lib.a
22452237

22462238
.PRECIOUS: $(TEST_OBJS)

0 commit comments

Comments
 (0)