Skip to content

Commit 1cb5887

Browse files
newrengitster
authored andcommitted
t6423: add an explanation about why one of the tests does not pass
I had long since forgotten the idea behind this test and why it failed, and took a little while to figure it out. To prevent others from having to spend a similar time on it, add an explanation in the comments. However, the reasoning in the explanation makes me question why I considered it a failure at all. I'm not sure if I had a better reason when I originally wrote it, but for now just add commentary about the possible expectations and why it behaves the way it does right now. Signed-off-by: Elijah Newren <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6c74948 commit 1cb5887

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

t/t6423-merge-rename-directories.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2843,6 +2843,14 @@ test_expect_success '9f: Renamed directory that only contained immediate subdirs
28432843
# Commit A: priority/{alpha,bravo}/$more_files
28442844
# Commit B: goal/{a,b}/$more_files, goal/c
28452845
# Expected: priority/{alpha,bravo}/$more_files, priority/c
2846+
# We currently fail this test because the directory renames we detect are
2847+
# goal/a/ -> priority/alpha/
2848+
# goal/b/ -> priority/bravo/
2849+
# We do not detect
2850+
# goal/ -> priority/
2851+
# because of no files found within goal/, and the fact that "a" != "alpha"
2852+
# and "b" != "bravo". But I'm not sure it's really a failure given that
2853+
# viewpoint...
28462854

28472855
test_setup_9g () {
28482856
test_create_repo 9g &&

0 commit comments

Comments
 (0)