prune-packed: only show progress when stderr is a tty

peff · gitster · commit 1ddf5efc66d9 · 2009-11-23T21:29:45.000-08:00
This matches the behavior of other git programs, and helps
keep cruft out of things like cron job output.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-prune-packed.c b/builtin-prune-packed.c
@@ -71,7 +71,7 @@ void prune_packed_objects(int opts)
 
 int cmd_prune_packed(int argc, const char **argv, const char *prefix)
 {
-	int opts = VERBOSE;
+	int opts = isatty(2) ? VERBOSE : 0;
 	const struct option prune_packed_options[] = {
 		OPT_BIT('n', "dry-run", &opts, "dry run", DRY_RUN),
 		OPT_NEGBIT('q', "quiet", &opts, "be quiet", VERBOSE),

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ void prune_packed_objects(int opts)`
`71`	`71`
`72`	`72`	`int cmd_prune_packed(int argc, const char *argv, const char prefix)`
`73`	`73`	`{`
`74`		`- int opts = VERBOSE;`
	`74`	`+ int opts = isatty(2) ? VERBOSE : 0;`
`75`	`75`	`const struct option prune_packed_options[] = {`
`76`	`76`	`OPT_BIT('n', "dry-run", &opts, "dry run", DRY_RUN),`
`77`	`77`	`OPT_NEGBIT('q', "quiet", &opts, "be quiet", VERBOSE),`