Skip to content

Commit 1f8b46d

Browse files
yangskyboxlabsgitster
authored andcommitted
git-p4: remove string type aliasing
Now that python2.7 is the minimum required version and we no longer use the basestring type, it is not necessary to use type aliasing to ensure python3 compatibility. Signed-off-by: Yang Zhao <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 484d09c commit 1f8b46d

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

git-p4.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,22 +26,6 @@
2626
import ctypes
2727
import errno
2828

29-
# support basestring in python3
30-
try:
31-
unicode = unicode
32-
except NameError:
33-
# 'unicode' is undefined, must be Python 3
34-
str = str
35-
unicode = str
36-
bytes = bytes
37-
basestring = (str,bytes)
38-
else:
39-
# 'unicode' exists, must be Python 2
40-
str = str
41-
unicode = unicode
42-
bytes = str
43-
basestring = basestring
44-
4529
verbose = False
4630

4731
# Only labels/tags matching this will be imported/exported

0 commit comments

Comments
 (0)