Skip to content

Commit 1fad503

Browse files
peffgitster
authored andcommitted
t/lib-httpd: pass through GIT_CONFIG_NOSYSTEM env
We set GIT_CONFIG_NOSYSTEM in our test scripts so that we do not accidentally read /etc/gitconfig and have it influence the outcome of the tests. But when running smart-http tests, Apache will clean the environment, including this variable, and the "server" side of our http operations will read it. You can see this breakage by doing something like: make ./git config --system http.getanyfile false make test which will cause t5561 to fail when it tests the fallback-to-dumb operation. We can fix this by instructing Apache to pass through the variable. Unlike with other variables (e.g., 89c57ab's GIT_TRACE), we don't need to set a dummy value to prevent warnings from Apache. test-lib.sh already makes sure that GIT_CONFIG_NOSYSTEM is set and exported. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 937978e commit 1fad503

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

t/lib-httpd/apache.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ PassEnv GIT_VALGRIND_OPTIONS
7171
PassEnv GNUPGHOME
7272
PassEnv ASAN_OPTIONS
7373
PassEnv GIT_TRACE
74+
PassEnv GIT_CONFIG_NOSYSTEM
7475

7576
Alias /dumb/ www/
7677
Alias /auth/dumb/ www/auth/dumb/

0 commit comments

Comments
 (0)