Skip to content

Commit 2059e79

Browse files
rscharfegitster
authored andcommitted
name-rev: use skip_prefix() instead of starts_with()
Let skip_prefix() advance refname to get rid of two magic numbers. Signed-off-by: René Scharfe <[email protected]> Acked-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1768aaf commit 2059e79

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

builtin/name-rev.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,10 @@ static const char *name_ref_abbrev(const char *refname, int shorten_unambiguous)
161161
{
162162
if (shorten_unambiguous)
163163
refname = shorten_unambiguous_ref(refname, 0);
164-
else if (starts_with(refname, "refs/heads/"))
165-
refname = refname + 11;
166-
else if (starts_with(refname, "refs/"))
167-
refname = refname + 5;
164+
else if (skip_prefix(refname, "refs/heads/", &refname))
165+
; /* refname already advanced */
166+
else
167+
skip_prefix(refname, "refs/", &refname);
168168
return refname;
169169
}
170170

0 commit comments

Comments
 (0)