builtin/submodule--helper: fix leaking error buffer

pks-t · gitster · commit 2266bb4f6a8a · 2024-09-27T08:25:34.000-07:00
Fix leaking error buffer when `compute_alternate_path()` fails.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
@@ -1621,6 +1621,8 @@ static int add_possible_reference_from_superproject(
 				; /* nothing */
 			}
 		}
+
+		strbuf_release(&err);
 		strbuf_release(&sb);
 	}
 
diff --git a/t/t7408-submodule-reference.sh b/t/t7408-submodule-reference.sh
@@ -4,6 +4,8 @@
 #
 
 test_description='test clone --reference'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 base_dir=$(pwd)

Original file line number	Diff line number	Diff line change
`@@ -1621,6 +1621,8 @@ static int add_possible_reference_from_superproject(`
`1621`	`1621`	`; /* nothing */`
`1622`	`1622`	`}`
`1623`	`1623`	`}`
	`1624`	`+`
	`1625`	`+ strbuf_release(&err);`
`1624`	`1626`	`strbuf_release(&sb);`
`1625`	`1627`	`}`
`1626`	`1628`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@`
`4`	`4`	`#`
`5`	`5`
`6`	`6`	`test_description='test clone --reference'`
	`7`	`+`
	`8`	`+TEST_PASSES_SANITIZE_LEAK=true`
`7`	`9`	`. ./test-lib.sh`
`8`	`10`
`9`	`11`	`base_dir=$(pwd)`