Skip to content

Commit 23e91c0

Browse files
jonathantanmygitster
authored andcommitted
gitformat-commit-graph: describe version 2 of BDAT
The code change to Git to support version 2 will be done in subsequent commits. Signed-off-by: Jonathan Tan <[email protected]> Signed-off-by: Junio C Hamano <[email protected]> Signed-off-by: Taylor Blau <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent cf73936 commit 23e91c0

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Documentation/gitformat-commit-graph.txt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,16 @@ All multi-byte numbers are in network byte order.
142142

143143
==== Bloom Filter Data (ID: {'B', 'D', 'A', 'T'}) [Optional]
144144
* It starts with header consisting of three unsigned 32-bit integers:
145-
- Version of the hash algorithm being used. We currently only support
146-
value 1 which corresponds to the 32-bit version of the murmur3 hash
145+
- Version of the hash algorithm being used. We currently support
146+
value 2 which corresponds to the 32-bit version of the murmur3 hash
147147
implemented exactly as described in
148148
https://en.wikipedia.org/wiki/MurmurHash#Algorithm and the double
149149
hashing technique using seed values 0x293ae76f and 0x7e646e2 as
150150
described in https://doi.org/10.1007/978-3-540-30494-4_26 "Bloom Filters
151-
in Probabilistic Verification"
151+
in Probabilistic Verification". Version 1 Bloom filters have a bug that appears
152+
when char is signed and the repository has path names that have characters >=
153+
0x80; Git supports reading and writing them, but this ability will be removed
154+
in a future version of Git.
152155
- The number of times a path is hashed and hence the number of bit positions
153156
that cumulatively determine whether a file is present in the commit.
154157
- The minimum number of bits 'b' per entry in the Bloom filter. If the filter

0 commit comments

Comments
 (0)