Skip to content

Commit 255a4da

Browse files
sorganovgitster
authored andcommitted
diff-merges: make -m/-c/--cc explicitly mutually exclusive
-c/--cc got precedence over -m only because of external logic where corresponding flags are checked before that for -m. This is too error-prone, so add code that explicitly makes these 3 options mutually exclusive, so that the last option specified on the command-line gets precedence. Signed-off-by: Sergey Organov <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 3d2b5f2 commit 255a4da

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

diff-merges.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ static void suppress(struct rev_info *revs)
88
revs->first_parent_merges = 0;
99
revs->combine_merges = 0;
1010
revs->dense_combined_merges = 0;
11+
revs->combined_all_paths = 0;
1112
}
1213

1314
static void set_separate(struct rev_info *revs)
@@ -29,12 +30,14 @@ static void set_m(struct rev_info *revs)
2930

3031
static void set_combined(struct rev_info *revs)
3132
{
33+
suppress(revs);
3234
revs->combine_merges = 1;
3335
revs->dense_combined_merges = 0;
3436
}
3537

3638
static void set_dense_combined(struct rev_info *revs)
3739
{
40+
suppress(revs);
3841
revs->combine_merges = 1;
3942
revs->dense_combined_merges = 1;
4043
}

0 commit comments

Comments
 (0)