Skip to content

Commit 2579e1d

Browse files
jlehmanngitster
authored andcommitted
tests: print failed test numbers at the end of the test run
On modern multi-core processors "make test" is often run in multiple jobs. If one of them fails the test run does stop, but the concurrently running tests finish their run. It is rather easy to find out which test failed by doing a "ls -d t/trash*". But that only works when you don't use the "-i" option to "make test" because you want to get an overview of all failing tests. In that case all thrash directories are deleted end and the information which tests failed is lost. If one or more tests failed, print a list of them before the test summary: failed test(s): t1000 t6500 fixed 0 success 7638 failed 3 broken 49 total 7723 This makes it possible to just run the test suite with -i and collect all failed test scripts at the end for further examination. Signed-off-by: Jens Lehmann <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b421812 commit 2579e1d

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

t/aggregate-results.sh

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#!/bin/sh
22

3+
failed_tests=
34
fixed=0
45
success=0
56
failed=0
@@ -18,7 +19,13 @@ do
1819
success)
1920
success=$(($success + $value)) ;;
2021
failed)
21-
failed=$(($failed + $value)) ;;
22+
failed=$(($failed + $value))
23+
if test $value != 0
24+
then
25+
testnum=$(expr "$file" : 'test-results/\(t[0-9]*\)-')
26+
failed_tests="$failed_tests $testnum"
27+
fi
28+
;;
2229
broken)
2330
broken=$(($broken + $value)) ;;
2431
total)
@@ -27,6 +34,11 @@ do
2734
done <"$file"
2835
done
2936

37+
if test -n "$failed_tests"
38+
then
39+
printf "\nfailed test(s):$failed_tests\n\n"
40+
fi
41+
3042
printf "%-8s%d\n" fixed $fixed
3143
printf "%-8s%d\n" success $success
3244
printf "%-8s%d\n" failed $failed

0 commit comments

Comments
 (0)