Skip to content

Commit 2607d39

Browse files
peffgitster
authored andcommitted
doc-diff: use single-colon rule in rendering Makefile
When rendering the troff manpages to text via "man", we create an ad-hoc Makefile and feed it to "make". The purpose here is two-fold: - reuse results from a prior interrupted render of the same tree - use make's -j option to build in parallel But the second part doesn't seem to work (at least with my version of GNU make, 4.2.1). It just runs one render at a time. We use a double-colon "all" rule for each file, like: all:: foo foo: ...actual render recipe... all:: bar bar: ...actual render recipe... ...and so on... And it's this double-colon that seems to inhibit the parallelism. We can just switch to a regular single-colon rule. Even though we do have multiple rules for "all" here, we don't have any recipe to execute for "all" (we only care about triggering its dependencies), so the distinction is irrelevant. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b6d4d82 commit 2607d39

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Documentation/doc-diff

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ generate_render_makefile () {
127127
while read src
128128
do
129129
dst=$2/${src#$1/}
130-
printf 'all:: %s\n' "$dst"
130+
printf 'all: %s\n' "$dst"
131131
printf '%s: %s\n' "$dst" "$src"
132132
printf '\t@echo >&2 " RENDER $(notdir $@)" && \\\n'
133133
printf '\tmkdir -p $(dir $@) && \\\n'

0 commit comments

Comments
 (0)