fixup! tests: introduce test_atexit

Turns out that there are problems with that approach that are totally
not related to Azure Pipelines, so in order to focus on the latter,
let's skip the test_atexit patches for now.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

t/t0000-basic.sh

@@ -825,24 +825,6 @@ test_expect_success 'tests clean up even on failures' "
 	EOF
 "
 
-test_expect_success 'test_atexit is run' "
-	test_must_fail run_sub_test_lib_test \
-		atexit-cleanup 'Run atexit commands' -i <<-\\EOF &&
-	test_expect_success 'tests clean up even after a failure' '
-		> ../../clean-atexit &&
-		test_atexit rm ../../clean-atexit &&
-		> ../../also-clean-atexit &&
-		test_atexit rm ../../also-clean-atexit &&
-		> ../../dont-clean-atexit &&
-		(exit 1)
-	'
-	test_done
-	EOF
-	test_path_exists dont-clean-atexit &&
-	test_path_is_missing clean-atexit &&
-	test_path_is_missing also-clean-atexit
-"
-
 test_expect_success 'test_oid setup' '
 	test_oid_init
 '

t/test-lib-functions.sh

@@ -927,35 +927,6 @@ test_when_finished () {
 		} && (exit \"\$eval_ret\"); eval_ret=\$?; $test_cleanup"
 }
 
-# This function can be used to schedule some commands to be run
-# unconditionally at the end of the test script, e.g. to stop a daemon:
-#
-#	test_expect_success 'test git daemon' '
-#		git daemon &
-#		daemon_pid=$! &&
-#		test_atexit "kill $daemon_pid" &&
-#		hello world
-#	'
-
-test_atexit () {
-	# We cannot detect when we are in a subshell in general, but by
-	# doing so on Bash is better than nothing (the test will
-	# silently pass on other shells).
-	test "${BASH_SUBSHELL-0}" = 0 ||
-	error "bug in test script: test_atexit does nothing in a subshell"
-	test_atexit_cleanup="{ $*
-		} && (exit \"\$eval_ret\"); eval_ret=\$?; $test_atexit_cleanup"
-}
-
-test_atexit_handler () {
-	test : != "$test_atexit_cleanup" || return 0
-
-	setup_malloc_check
-	test_eval_ "$test_atexit_cleanup"
-	test_atexit_cleanup=:
-	teardown_malloc_check
-}
-
 # Most tests can use the created repository, but some may need to create more.
 # Usage: test_create_repo <directory>
 test_create_repo () {

t/test-lib.sh

@@ -481,7 +481,6 @@ test_external_has_tap=0
 
 die () {
 	code=$?
-	test_atexit_handler || code=$?
 	if test -n "$GIT_EXIT_OK"
 	then
 		exit $code
@@ -931,12 +930,9 @@ write_junit_xml_testcase () {
 	junit_have_testcase=t
 }
 
-test_atexit_cleanup=:
 test_done () {
 	GIT_EXIT_OK=t
 
-	test -n "$immediate" || test_atexit_handler
-
 	if test -n "$write_junit_xml" && test -n "$junit_xml_path"
 	then
 		test -n "$junit_have_testcase" || {