Skip to content

Commit 26517de

Browse files
committed
Merge branch 'rs/maint-diff-fd-leak' into maint
* rs/maint-diff-fd-leak: close file on error in read_mmfile()
2 parents c2ed29b + 5fd8981 commit 26517de

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

xdiff-interface.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,10 @@ int read_mmfile(mmfile_t *ptr, const char *filename)
212212
return error("Could not open %s", filename);
213213
sz = xsize_t(st.st_size);
214214
ptr->ptr = xmalloc(sz ? sz : 1);
215-
if (sz && fread(ptr->ptr, sz, 1, f) != 1)
215+
if (sz && fread(ptr->ptr, sz, 1, f) != 1) {
216+
fclose(f);
216217
return error("Could not read %s", filename);
218+
}
217219
fclose(f);
218220
ptr->size = sz;
219221
return 0;

0 commit comments

Comments
 (0)